Conversation
packages/integration_test/README.md
Outdated
|
|
||
| This package has been moved to the Flutter SDK. Starting with Flutter 2.0, | ||
| it should be included as: | ||
| This package has been [moved to the Flutter |
There was a problem hiding this comment.
I'm not convinced this is clearer; "moved" isn't generally a meaningful term for clients of a package (since where the source lives is generally irrelevant). The version on pub, where users are likely to be reading this, is deprecated.
There was a problem hiding this comment.
The version on Pub is deprecated, but the package isn't. We don't want to give the impression that integration testing should be done some other way. @sfshaza2 do you have any input here?
There was a problem hiding this comment.
I made some suggested changes to the text.
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Looks like we never got resolution on this. I'm fine to go ahead and land it, but you'll need to merge in the latest master so that the tests are green (re-running the flake will fail since this is so old.)
sfshaza2
left a comment
sfshaza2
left a comment
There was a problem hiding this comment.
I've made a few suggested tweaks. I never saw this back in April!
|
@johnpryan Are you still planning on updating this? |
|
Thanks for the reminder - I'll update this! |
- add a link to the flutter.dev docs - add a link to the new location - Changed "deprecated" to "moved" to avoid confusion, since this is still the recommended way to write unit tests, but needs to be imported differently.
johnpryan
requested review from
LHLL,
bparrishMines,
cyanglaz,
ditman and
gaaclarke
as code owners
github-actions
bot
added
p: android_alarm_manager
p: android_intent
p: battery
github-actions
bot
removed
platform-android
p: video_player
p: espresso
p: flutter_plugin_android_lifecycle
p: android_alarm_manager
p: camera
p: path_provider
p: device_info
platform-ios
p: ios_platform_images
platform-web
p: wifi_info_flutter
p: plugin_platform_interface
p: shared_preferences
p: image_picker
p: file_selector
p: quick_actions
platform-macos
platform-windows
p: google_maps_flutter
p: connectivity
p: url_launcher
p: in_app_purchase
labels
|
Ready for another look... sorry for the mess |
3 participants
Changes "deprecated" to "moved" to avoid confusion, since this is still the recommended way to write unit tests, but needs to be imported differently. Also adds a link to the flutter.dev docs + the new location.
FYI @sfshaza2