[path_provider_windows], [path_provider_linux], [path_provider_platform_interface] update dependencies#3818
[path_provider_windows], [path_provider_linux], [path_provider_platform_interface] update dependencies#3818mrquantumoff wants to merge 1 commit intoflutter:mainfrom
Conversation
|
Thanks for the contribution, but this isn't a change we would accept.
The current version of
1.x is less than 2.0, so is allowed by the current constraint.
This is a feature for a library; we don't artificially limit what versions of packages people can use. See also specific notes below. |
|
|
||
| environment: | ||
| sdk: ">=2.17.0 <4.0.0" | ||
| sdk: ">=2.19.0 <4.0.0" |
There was a problem hiding this comment.
This would prevent Flutter 3.0 and 3.3 users from using this package, without any benefit.
|
|
||
| dependencies: | ||
| ffi: ">=1.1.2 <3.0.0" | ||
| ffi: ">=2.0.1" |
There was a problem hiding this comment.
This removes compatibility with ffi 1.x without any benefit, creating more potential conflicts in the ecosystem.
| path_provider_platform_interface: ^2.0.0 | ||
| xdg_directories: ">=0.2.0 <2.0.0" | ||
| path: ^1.8.2 | ||
| path_provider_platform_interface: ^2.0.6 |
There was a problem hiding this comment.
Nothing in this package requires these bugfix versions; this artificially prevents clients from using earlier versions if they have a specific need to do so.
| xdg_directories: ">=0.2.0 <2.0.0" | ||
| path: ^1.8.2 | ||
| path_provider_platform_interface: ^2.0.6 | ||
| xdg_directories: ">=1.0.0" |
There was a problem hiding this comment.
This removes compatibility with version 0.2.0 for no reason (the APIs are identical), creating more potential conflicts in the ecosystem.
There was a problem hiding this comment.
All the same comments apply to the other files as well.
| win32: ">=2.1.0 <4.0.0" | ||
| path: ^1.8.2 | ||
| path_provider_platform_interface: ^2.0.6 | ||
| win32: "^4.1.3" |
There was a problem hiding this comment.
This unnecessarily removes compatibility with win32 2.x and 3.x, creating more potential conflicts in the ecosystem.
2 participants
I updated GNU+Linux, Windows, and platform_interface dependencies, since some of my app's other dependencies were having issues with packages like win32 of v2.0
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.