Skip to content

[pigeon] Null safe requires Dart 2.12#252

Merged
blasten merged 23 commits intoflutter:masterfrom
blasten:null_safe_pigeon
Feb 2, 2021
Merged

[pigeon] Null safe requires Dart 2.12#252
blasten merged 23 commits intoflutter:masterfrom
blasten:null_safe_pigeon

Conversation

@blasten
Copy link
Contributor

@blasten blasten commented Dec 1, 2020

This is required after the beta announce.

@blasten blasten requested review from gaaclarke and xster December 1, 2020 23:47
gaaclarke
gaaclarke approved these changes Dec 11, 2020
View reviewed changes
Copy link
Member

@gaaclarke gaaclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! pPease update the pubspec.yaml and generator_tools.dart.

@blasten blasten force-pushed the null_safe_pigeon branch 3 times, most recently from e7b1ce6 to cdf4454 Compare December 15, 2020 04:20
@blasten blasten mentioned this pull request Dec 18, 2020
Merged
@gaaclarke
Copy link
Member

gaaclarke commented Feb 1, 2021

Any idea what's going on with that test? Looks like there is a nil value for cached_framework_dir.

packages/packages/pigeon/e2e_tests/test_objc/ios/Podfile

Line 55 in 0e3e175

FileUtils.cp_r(File.join(cached_framework_dir, 'Flutter.framework'), copied_flutter_dir)

I didn't write that Podfile, it was either autogenerated by flutter or provided by e2e somehow.

xster
xster reviewed Feb 1, 2021
View reviewed changes
.cirrus.yml Outdated
name: local_tests
osx_instance:
image: catalina-flutter
image: high-sierra-xcode-9.4.1
Copy link
Member

@xster xster Feb 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are changes to this file intentional?

Copy link
Contributor Author

@blasten blasten Feb 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. This was for debugging purposes.

@blasten
Copy link
Contributor Author

blasten commented Feb 1, 2021

@gaaclarke I am able to repro this issue locally: https://github.com/flutter/packages/runs/1809227404 - Do you know what might be causing it?

@gaaclarke
Copy link
Member

gaaclarke commented Feb 1, 2021

Yep, you have to remove xcpretty from the local_tests. I did it in an external contributors PR yet but it hasn't landed yet.

@blasten
Copy link
Contributor Author

blasten commented Feb 2, 2021

🎉 finally

@blasten blasten merged commit 6740a21 into flutter:master Feb 2, 2021
@blasten blasten deleted the null_safe_pigeon branch February 2, 2021 18:29
austinstoker pushed a commit to austinstoker/packages that referenced this pull request Apr 29, 2022
@slovnicki
cleanup main README
a191056 
	- closes flutter#252
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xster xster xster left review comments

@gaaclarke gaaclarke gaaclarke approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@blasten @gaaclarke @xster