feat(a2ui_message): make toJson compatible with fromJson#780
Open
matiasleyba wants to merge 1 commit intoflutter:mainfrom
Open
feat(a2ui_message): make toJson compatible with fromJson#780matiasleyba wants to merge 1 commit intoflutter:mainfrom
matiasleyba wants to merge 1 commit intoflutter:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the toJson() methods for A2uiMessage subclasses to make them compatible with A2uiMessage.fromJson(), enabling round-trip serialization. The changes are well-implemented and include corresponding updates to tests and new round-trip tests. My feedback focuses on improving maintainability by using constants for repeated string literals like the API version and JSON keys, and a minor cleanup in the new test code.
c8c6d5b to
1e42529
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A2uiMessagesubclass’stoJson()now returns the wrapped envelope (version + one of createSurface / updateComponents / updateDataModel / deleteSurface) instead of a flat payload.A2uiMessage.fromJson()expects, so round-trip works.Why
A2uiMessage.fromJson(saved).fromJson(message.toJson())failed because the root map had no action key.CreateSurface,UpdateComponents, etc.) and build JSON per variant.message.toJson()on anyA2uiMessageand save without type checks.CreateSurface,UpdateComponents,UpdateDataModel, andDeleteSurfacenow put their payload under the corresponding key.Round-trip tests were added
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-devrel channel on Discord.