Skip to content

feat(fcm): Add support for restricted satellite API#1191

Open
jonathanedey wants to merge 1 commit intomainfrom
je-satellite-apis
Open

feat(fcm): Add support for restricted satellite API#1191
jonathanedey wants to merge 1 commit intomainfrom
je-satellite-apis

Conversation

@jonathanedey
Copy link
Collaborator

This change introduces the restrictedSatelliteOk configuration option for Android push notifications, providing developers with the ability to opt-in to delivering messages even when a user's device is connected via a restricted satellite network. This PR also follows up #1145 , to update the description for bandwidthConstrainedOk.

@jonathanedey jonathanedey added release-note release:stage Stage a release candidate labels Mar 3, 2026
@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new configuration option for Android push notifications in Firebase Cloud Messaging, enabling developers to explicitly allow message delivery even when a device is connected via a restricted satellite network. It also includes a minor update to the description of an existing network-related setting for better understanding.

Highlights

  • New Configuration Option: Added restrictedSatelliteOk to AndroidConfig for Firebase Cloud Messaging, allowing messages to be delivered over restricted satellite networks.
  • Documentation Update: Updated the description for the bandwidthConstrainedOk configuration option for improved clarity.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • src/main/java/com/google/firebase/messaging/AndroidConfig.java
    • Introduced a new restrictedSatelliteOk boolean field.
    • Added initialization for restrictedSatelliteOk in the constructor.
    • Included restrictedSatelliteOk in the Builder class.
    • Implemented a setRestrictedSatelliteOk method in the Builder to configure the new option.
    • Revised the Javadoc description for the setBandwidthConstrainedOk method.
  • src/test/java/com/google/firebase/messaging/MessageTest.java
    • Removed an unused import statement for com.google.api.client.googleapis.util.Utils.
    • Added a new test case testAndroidMessageWithRestrictedSatelliteOk to verify the functionality of the new configuration option.
    • Updated the type parameter for the Map in the assertJsonEquals method signature to Map<String, Object> for better type safety.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for the restricted_satellite_ok option for Android push notifications. The changes include adding the new field to AndroidConfig and its builder, along with a new test case to verify the functionality. The implementation is straightforward and follows existing patterns. I've identified an opportunity to improve test code maintainability by refactoring duplicated test logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release:stage Stage a release candidate release-note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants