Skip to content

Fix pre-commit warning and change '.h5' to '.keras' for written output#1006

Merged
jmitrevs merged 2 commits intomainfrom
pre-commit-and-keras
May 3, 2024
Merged

Fix pre-commit warning and change '.h5' to '.keras' for written output#1006
jmitrevs merged 2 commits intomainfrom
pre-commit-and-keras

Conversation

@jmitrevs
Copy link
Contributor

Description

When running pytests with the new docker image from #1005, some tests fail due to the writing of an .h5 file for reference in the output directory. It is considered depricated, and .keras is recommended. That is what this PR does.

One issue with doing this is that we would have to enforce a fairly new version of keras. But that may be fine if we move to 3.10 as our minimal python version in the near future. However, since this merits more discussion, I separated it from #1005.

The latest pre-commit flags the lack of a space after a comma, which this PR adds, though I am not convinced it better with the space.

Type of change

For a new feature or function, please create an issue first to discuss it
with us before submitting a pull request.

Note: Please delete options that are not relevant.

  • Bug fix (non-breaking change that fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Tests

The point is to fix already failing tests. Note, pytests won't actually be run till after #1005 is merged.

Checklist

  • I have read the guidelines for contributing.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have installed and run pre-commit on the files I edited or added.
  • I have added tests that prove my fix is effective or that my feature works.

@jmitrevs jmitrevs merged commit ed55394 into main May 3, 2024
@jmitrevs jmitrevs deleted the pre-commit-and-keras branch May 3, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant