Fix pre-commit warning and change '.h5' to '.keras' for written output#1006
Merged
Fix pre-commit warning and change '.h5' to '.keras' for written output#1006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When running pytests with the new docker image from #1005, some tests fail due to the writing of an .h5 file for reference in the output directory. It is considered depricated, and .keras is recommended. That is what this PR does.
One issue with doing this is that we would have to enforce a fairly new version of keras. But that may be fine if we move to 3.10 as our minimal python version in the near future. However, since this merits more discussion, I separated it from #1005.
The latest pre-commit flags the lack of a space after a comma, which this PR adds, though I am not convinced it better with the space.
Type of change
For a new feature or function, please create an issue first to discuss it
with us before submitting a pull request.
Note: Please delete options that are not relevant.
Tests
The point is to fix already failing tests. Note, pytests won't actually be run till after #1005 is merged.
Checklist
pre-commiton the files I edited or added.