[bug] remove decode() because type is str not bytes#862
Closed
bolinfest wants to merge 1 commit intofacebook:mainfrom
Closed
[bug] remove decode() because type is str not bytes#862bolinfest wants to merge 1 commit intofacebook:mainfrom
bolinfest wants to merge 1 commit intofacebook:mainfrom
Conversation
Contributor
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
FYI, I discovered this because I tried using the devcontainer stuff introduced in facebook#807, so from the Docker container launched by VS Code, I tried running: ``` ./tests/run-tests.py ./tests/test-doctest.py ``` It prints out the following: ``` WARNING: Did not find prerequisite tool: unzip ``` I guess that means `unzip` doesn't get installed as part of the Docker container, though I suppose it isn't a big deal? That is, this is just a warning and the test passes just fine.
Contributor
|
@bolinfest has updated the pull request. You must reimport the pull request before landing. |
Contributor
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@quark-zju merged this pull request in 383da2a. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[bug] remove decode() because type is str not bytes