Skip to content

fix mononoke build#769

Closed
ahornby wants to merge 1 commit intofacebook:mainfrom
ahornby:pr769
Closed

fix mononoke build#769
ahornby wants to merge 1 commit intofacebook:mainfrom
ahornby:pr769

Conversation

@ahornby
Copy link
Contributor

@ahornby ahornby commented Nov 10, 2023

fix mononoke build

Makes usage of anyhow::Error::backtrace() conditional on fbcode_build. This is necessary because the cargo build of anyhow disables its backtrace features when using RUSTC_BOOTSTRAP=1

For oss cargo build to work on current rustc stable 1.73+ I hid the #![feature(provide_any)] usage by making it condition on fbcode_build.

Test plan:

local build with ./build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. mononoke

github CI, done by regenerating the mononoke github actions with: ./build/fbcode_builder/getdeps.py --allow-system-packages generate-github-actions --free-up-disk --src-dir=. --output-dir=.github/workflows --job-name="Mononoke " --job-file-prefix=mononoke_ mononoke

Before, broken

After, works

@facebook-github-bot
Copy link
Contributor

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@xavierd
Copy link
Contributor

xavierd commented Nov 13, 2023

For build to work on current rustc stable 1.73+ I had to remove the #![feature(provide_any)] usage. You may need to be on rustc 1.73+ internally to import this successfully

It looks like our internal build is unfortunately failing to build. The compiler is sending us to rust-lang/rust#96024 which appears to still be open. Can you re-send this PR while keeping the feature?

Makes usage of anyhow::Error::backtrace() conditional on fbcode_build. This is necessary because the cargo build of anyhow disables its backtrace features when using RUSTC_BOOTSTRAP=1

For oss cargo build to work on current rustc stable 1.73+ I hid the #![feature(provide_any)] usage by making it condition on fbcode_build.

Test plan:

local build with `./build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. mononoke`

github CI, done by regenerating the mononoke github actions with: `./build/fbcode_builder/getdeps.py --allow-system-packages generate-github-actions --free-up-disk --src-dir=. --output-dir=.github/workflows --job-name="Mononoke " --job-file-prefix=mononoke_ mononoke`

Before, broken

After, works
@facebook-github-bot
Copy link
Contributor

@ahornby has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@ahornby
Copy link
Contributor Author

ahornby commented Nov 13, 2023

It looks like our internal build is unfortunately failing to build. The compiler is sending us to rust-lang/rust#96024 which appears to still be open. Can you re-send this PR while keeping the feature?

done, added in cfg_attr usage to keep it off in oss build but on otherwise

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 41e6e88.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants