skip stats if setup-ccache did not run or failed#14542
Closed
mszeszko-meta wants to merge 1 commit intofacebook:mainfrom
Closed
skip stats if setup-ccache did not run or failed#14542mszeszko-meta wants to merge 1 commit intofacebook:mainfrom
mszeszko-meta wants to merge 1 commit intofacebook:mainfrom
Conversation
|
@mszeszko-meta has imported this pull request. If you are a Meta employee, you can view this in D98964757. |
✅ clang-tidy: No findings on changed linesCompleted in 0.0s. |
joshkang97
approved these changes
Mar 31, 2026
Contributor
joshkang97
left a comment
joshkang97
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
|
@mszeszko-meta merged this pull request in 1e23ee0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
teardown-ccacheruns with if: always(), but in folly jobssetup-follyprecedessetup-ccache. Whensetup-follyfails,setup-ccacheis skipped, soCCACHE_DIRis unset and ccache is not onPATH. This is exactly what happened here. Fix guardsteardown-ccacheto exit gracefully whenCCACHE_DIRis unset, and tolerate missing ccache binary for stats.