Skip to content

Remove enableComponentStackLocations#31764

Merged
rickhanlonii merged 1 commit intofacebook:mainfrom
rickhanlonii:rh/rm-ff-component-stacks
Dec 13, 2024
Merged

Remove enableComponentStackLocations#31764
rickhanlonii merged 1 commit intofacebook:mainfrom
rickhanlonii:rh/rm-ff-component-stacks

Conversation

@rickhanlonii
Copy link
Member

@rickhanlonii rickhanlonii commented Dec 13, 2024

This has landed everywhere

@vercel
Copy link

vercel bot commented Dec 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 8:46pm

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Dec 13, 2024
rickhanlonii
rickhanlonii commented Dec 13, 2024
View reviewed changes
packages/shared/ReactComponentStackFrame.js
return describeNativeComponentFrame(ctor, true);
}

export function describeFunctionComponentFrame(fn: Function): string {
Copy link
Member Author

@rickhanlonii rickhanlonii Dec 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sebmarkbage we need to keep this old export to support old devtools versions right?

Copy link
Contributor

@sebmarkbage sebmarkbage Dec 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DevTools has its own copy in DevToolsComponentStackFrame so it can be deleted.

Copy link
Contributor

@sebmarkbage sebmarkbage Dec 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This export seems used by other places still though.

Copy link
Member Author

@rickhanlonii rickhanlonii Dec 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed this before merging somehow: #31781

@react-sizebot
Copy link

react-sizebot commented Dec 13, 2024

Comparing: 08dfd0b8053d8d712607d3f37ddbb4da00c351f1...5efb3ffcd32f778ff48d4d9c85092d6dbe163975

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 510.41 kB 510.34 kB = 91.35 kB 91.33 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 515.32 kB 515.25 kB = 92.04 kB 92.02 kB
facebook-www/ReactDOM-prod.classic.js = 595.25 kB 595.18 kB = 105.02 kB 105.01 kB
facebook-www/ReactDOM-prod.modern.js = 585.51 kB 585.44 kB = 103.46 kB 103.45 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against d96eecb

sebmarkbage
sebmarkbage approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@sebmarkbage sebmarkbage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol. We're even on the next version after this one now with enableOwnerStacks.

@rickhanlonii rickhanlonii mentioned this pull request Dec 13, 2024
Merged
@rickhanlonii rickhanlonii merged commit 3ad17ec into facebook:main Dec 13, 2024
@rickhanlonii rickhanlonii deleted the rh/rm-ff-component-stacks branch December 13, 2024 20:52
github-actions bot pushed a commit that referenced this pull request Dec 13, 2024
@rickhanlonii
Remove enableComponentStackLocations (#31764)
b80e295 
This has landed everywhere

DiffTrain build for [3ad17ec](3ad17ec)
github-actions bot pushed a commit that referenced this pull request Dec 13, 2024
@rickhanlonii
Remove enableComponentStackLocations (#31764)
1b27d1e 
This has landed everywhere

DiffTrain build for [3ad17ec](3ad17ec)
rickhanlonii added a commit that referenced this pull request Dec 13, 2024
@rickhanlonii
Remove enableFilterEmptyStringAttributesDOM (#31765)
4996a8f 
Base off #31764

This has landed everywhere
github-actions bot pushed a commit that referenced this pull request Dec 13, 2024
@rickhanlonii
Remove enableFilterEmptyStringAttributesDOM (#31765)
e67f32f 
Base off #31764

This has landed everywhere

DiffTrain build for [4996a8f](4996a8f)
github-actions bot pushed a commit that referenced this pull request Dec 13, 2024
@rickhanlonii
Remove enableFilterEmptyStringAttributesDOM (#31765)
ed63850 
Base off #31764

This has landed everywhere

DiffTrain build for [4996a8f](4996a8f)
This was referenced Dec 18, 2024
Closed
Closed
Closed
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sebmarkbage sebmarkbage sebmarkbage approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rickhanlonii @react-sizebot @sebmarkbage @facebook-github-bot