Avoid GCC optimizations affecting function arity#31598
Closed
eps1lon wants to merge 2 commits intofacebook:mainfrom
Closed
Avoid GCC optimizations affecting function arity#31598eps1lon wants to merge 2 commits intofacebook:mainfrom
eps1lon wants to merge 2 commits intofacebook:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
eps1lon
changed the title
facebook-github-bot
added
the
React Core Team
anandfresh
reviewed
Nov 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems to not work. May have to wait for #31587
Summary
Closes #31578
How did you test this change?
Lint against optimization. It's more noisy than it needs to but I was too lazy to avound for every possible kind of function syntax.
You can also
yarn build react-dom/client --type=NODE_DEVto check thatJSCompiler_OptimizeArgumentsArray_still replacesarguments.