Flare: change flushDiscreteUpdates invariant to warning#15702
Merged
trueadm merged 1 commit intofacebook:masterfrom May 22, 2019
Merged
Flare: change flushDiscreteUpdates invariant to warning#15702trueadm merged 1 commit intofacebook:masterfrom
trueadm merged 1 commit intofacebook:masterfrom
Conversation
acdlite
approved these changes
May 21, 2019
acdlite
reviewed
May 21, 2019
| expect(() => { | ||
| node.click(); | ||
| }).toWarnDev( | ||
| 'Warning: unstable_flushDiscreteUpdates: Cannot flush updates when React is already rendering.', |
Collaborator
There was a problem hiding this comment.
Should bikeshed this message before it hits open source
Contributor
Author
There was a problem hiding this comment.
I'll leave you the key to the bikeshed. Help yourself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When testing #15687 internally, we encountered some issues where the invariant in flushDiscreteUpdates fired during legit tests. On further inspection, using
invariantwas maybe too strong, so this has been downgraded to awarningin DEV.