WIP: Use all relative paths for header_mappings_dir option in podspecs#39178
Closed
koenpunt wants to merge 2 commits intofacebook:mainfrom
Closed
WIP: Use all relative paths for header_mappings_dir option in podspecs#39178koenpunt wants to merge 2 commits intofacebook:mainfrom
header_mappings_dir option in podspecs#39178koenpunt wants to merge 2 commits intofacebook:mainfrom
Conversation
facebook-github-bot
added
the
CLA Signed
koenpunt
changed the title
header_mappings_dir option in podspecs
|
|
This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
github-actions
bot
added
the
Stale
|
This PR was closed because it has been stalled for 7 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Possible follow-up for #39177
From what I understand from the
header_mappings_diris that it basically a relative path from the pods source root, and since all previous paths pointed to the root level of the pod's source roots I think having them all use./should result in all header structures being preserved.https://www.rubydoc.info/gems/cocoapods-core/0.38.2/Pod%2FSpecification%2FDSL:header_mappings_dir=
Changelog:
Test Plan: