Adjust RawPropsPropNameLength's type to account for increased number of props#39008
Closed
vincentriemer wants to merge 1 commit intofacebook:mainfrom
Closed
Adjust RawPropsPropNameLength's type to account for increased number of props#39008vincentriemer wants to merge 1 commit intofacebook:mainfrom
vincentriemer wants to merge 1 commit intofacebook:mainfrom
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48331909 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48331909 |
vincentriemer
force-pushed
the
export-D48331909
branch
from
07c3152 to
0485cab
Compare
Base commit: b012027 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48331909 |
vincentriemer
force-pushed
the
export-D48331909
branch
from
0485cab to
b593b85
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48331909 |
vincentriemer
force-pushed
the
export-D48331909
branch
from
b593b85 to
778def8
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48331909 |
vincentriemer
force-pushed
the
export-D48331909
branch
from
778def8 to
35fbe20
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48331909 |
vincentriemer
force-pushed
the
export-D48331909
branch
from
35fbe20 to
411c6c2
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48331909 |
vincentriemer
force-pushed
the
export-D48331909
branch
from
411c6c2 to
3dfb5d1
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48331909 |
vincentriemer
force-pushed
the
export-D48331909
branch
from
3dfb5d1 to
ff4c41e
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48331909 |
vincentriemer
force-pushed
the
export-D48331909
branch
from
ff4c41e to
ed51fe1
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48331909 |
vincentriemer
force-pushed
the
export-D48331909
branch
from
ed51fe1 to
0a993a3
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48331909 |
…of props (facebook#39008) Summary: Pull Request resolved: facebook#39008 Changelog: [Internal] - Adjust RawPropsPropNameLength's type to account for increased number of props While investigating why we needed to back out D48288752 I discovered that the root cause was that the `items_` vector in `RawProsKeyMap` was now a size greater than 255 which becomes an issue because `items_`'s indices are statically cast to `RawPropsPropNameLength` (previously alias to `uint8_t`). This diff updates `RawPropsPropNameLength` to be an alias to `uint16_t` so the current issue is resolved as well as adding an assert to ensure (however unlikely) that this happens again. Reviewed By: rozele Differential Revision: D48331909 fbshipit-source-id: 86a2b67bdf5090616252e9eea9165e7752793bc1
vincentriemer
force-pushed
the
export-D48331909
branch
from
0a993a3 to
ceb024a
Compare
|
This pull request was successfully merged by @vincentriemer in 894b883. When will my fix make it into a release? | Upcoming Releases |
Contributor
|
This pull request has been merged in 894b883. |
fortmarek
pushed a commit
that referenced
this pull request
Sep 4, 2023
…of props (#39008) Summary: Pull Request resolved: #39008 Changelog: [Internal] - Adjust RawPropsPropNameLength's type to account for increased number of props While investigating why we needed to back out D48288752 I discovered that the root cause was that the `items_` vector in `RawProsKeyMap` was now a size greater than 255 which becomes an issue because `items_`'s indices are statically cast to `RawPropsPropNameLength` (previously alias to `uint8_t`). This diff updates `RawPropsPropNameLength` to be an alias to `uint16_t` so the current issue is resolved as well as adding an assert to ensure (however unlikely) that this happens again. Reviewed By: rozele Differential Revision: D48331909 fbshipit-source-id: f6bc3e4825f2f293d79d8cd90c40ced7cba0e3c5
This was referenced Jan 4, 2024
This was referenced Feb 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal] - Adjust RawPropsPropNameLength's type to account for increased number of props
While investigating why we needed to back out D48288752 I discovered that the root cause was that the
items_vector inRawProsKeyMapwas now a size greater than 255 which becomes an issue becauseitems_'s indices are statically cast toRawPropsPropNameLength(previously alias touint8_t).This diff updates
RawPropsPropNameLengthto be an alias touint16_tso the current issue is resolved as well as adding an assert to ensure (however unlikely) that this happens again.Differential Revision: D48331909