👌 Improve performance of "text" inline rule#347
Merged
chrisjsewell merged 2 commits intoexecutablebooks:masterfrom Dec 17, 2024
Merged
👌 Improve performance of "text" inline rule#347chrisjsewell merged 2 commits intoexecutablebooks:masterfrom
chrisjsewell merged 2 commits intoexecutablebooks:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #347 +/- ##
=======================================
Coverage 95.24% 95.25%
=======================================
Files 64 64
Lines 3431 3436 +5
=======================================
+ Hits 3268 3273 +5
Misses 163 163
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
yeh looks good cheers |
chrisjsewell
approved these changes
Dec 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This slightly deviates from JavaScript, but improves performance a lot.
Below the before/after results from
tox -e py312-bench-core.Before:
After: