Conversation
Codecov Report
@@ Coverage Diff @@
## master #213 +/- ##
=======================================
Coverage 96.08% 96.08%
=======================================
Files 62 62
Lines 3221 3221
=======================================
Hits 3095 3095
Misses 126 126
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
hukkin
left a comment
There was a problem hiding this comment.
I don't object either version.
Personally I'd do 3.0 mainly because of Remove deprecated NestedTokens and nest_tokens. The deprecation is a nice warning, but if we strictly follow SemVer, I don't think it makes the removals any less breaking.
|
If you plan to merge #214 it may be a good idea to do so before the release. Merging it afterwards will introduce a breaking change, as |
@hukkin do you have any objections, regarding releasing this as 2.1 rather than 3.0?
Fo 99% of use cases, I don't think there should be a noticeable change, moving from attrs to dataclasses (it certainly did not affect myst-parser)