Skip to content

feat: CI/CD setup#903

Merged
Bidon15 merged 3 commits intoevstack:mainfrom
smuu:feature/ci-cd-setup
Apr 27, 2023
Merged

feat: CI/CD setup#903
Bidon15 merged 3 commits intoevstack:mainfrom
smuu:feature/ci-cd-setup

Conversation

@smuu
Copy link
Contributor

@smuu smuu commented Apr 26, 2023

Part of EPIC https://github.com/celestiaorg/devops/issues/112

Note: When merging this PR, the required checks for each PR break and need to be updated.

These changes enhance the project's CI/CD pipeline, streamline the linting and testing process, and add new checks and tasks to the workflows.
Here's a summary of the changes:

  • A new file, .github/workflows/ci_release.yml is created. This workflow is responsible for linting, testing, and releasing the project. It is triggered on push to the main branch, version tags, and pull requests. The workflow also accepts manual triggers with inputs for the new version's semantic version type (major, minor, or patch).
  • The existing file .github/workflows/docker-build-da-mockserv.yml is updated to change the tags regex for triggering the workflow.
  • The existing file .github/workflows/lint.yml is modified to change the triggers to a workflow_call. This means that the workflow is now meant to be called by other workflows instead of triggered directly by events like push or pull_request. Also, a new job, protobuf-lint is added to this workflow.
  • A new file, .github/workflows/proto.yml is created. This workflow checks if the generated protobuf code matches the committed code. It is also triggered by a workflow_call.
  • The existing file .github/workflows/test.yml is updated to change the workflow name and triggers to a workflow_call. It also adds new jobs: go_mod_tidy_check, test_coverage, unit_test, unit_race_test, and integration_test.
  • The .gitignore file is updated to ignore the coverage.txt file.
  • A new Makefile is created, which provides various commands for generating code coverage reports, running unit tests, running unit tests with data race detector, and generating and linting protobuf files.
  • The buf.yaml file is updated to add more lint rules and ignore the tendermint directory.

These changes enhance the project's CI/CD pipeline, streamline the linting and testing process, and add new checks and tasks to the workflows.

Once the PR is merged, please try the create release when manually triggering the workflow.

Closes https://github.com/celestiaorg/devops/issues/257, closes https://github.com/celestiaorg/devops/issues/258, closes https://github.com/celestiaorg/devops/issues/259
Closes #804

@smuu smuu force-pushed the feature/ci-cd-setup branch from 2494896 to 882d7a9 Compare April 26, 2023 10:16
@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.19 ⚠️

Comparison is base (66d7e50) 56.10% compared to head (4db6a34) 55.91%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #903      +/-   ##
==========================================
- Coverage   56.10%   55.91%   -0.19%     
==========================================
  Files          66       66              
  Lines       10705    10705              
==========================================
- Hits         6006     5986      -20     
- Misses       3831     3848      +17     
- Partials      868      871       +3     

see 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@smuu smuu requested review from Bidon15 and tty47 April 26, 2023 10:28
@smuu smuu marked this pull request as ready for review April 26, 2023 10:39
Copy link
Collaborator

@tty47 tty47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@Bidon15 Bidon15 enabled auto-merge April 26, 2023 13:49
@nashqueue
Copy link
Contributor

How can we merge a change to CI while CI is changing? @smuu @Bidon15 This is ready to merge

smuu added 3 commits April 27, 2023 10:23
Signed-off-by: Smuu <18609909+Smuu@users.noreply.github.com>
Signed-off-by: Smuu <18609909+Smuu@users.noreply.github.com>
Signed-off-by: Smuu <18609909+Smuu@users.noreply.github.com>
@Bidon15 Bidon15 force-pushed the feature/ci-cd-setup branch from 741006a to 4db6a34 Compare April 27, 2023 08:23
@Bidon15 Bidon15 merged commit 931c35c into evstack:main Apr 27, 2023
@smuu smuu deleted the feature/ci-cd-setup branch April 27, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create a make file for Rollkit

5 participants