Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #888 +/- ##
==========================================
+ Coverage 55.17% 56.09% +0.92%
==========================================
Files 54 66 +12
Lines 9985 10698 +713
==========================================
+ Hits 5509 6001 +492
- Misses 3656 3829 +173
- Partials 820 868 +48
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
nashqueue
previously approved these changes
Apr 24, 2023
Contributor
nashqueue
left a comment
There was a problem hiding this comment.
Approve, as this is just a copy-paste from core and will be extracted later. ![]()
tzdybal
reviewed
Apr 24, 2023
nashqueue
approved these changes
Apr 24, 2023
gupadhyaya
approved these changes
Apr 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #887
Copy parts of share package relating to compact shares. We plan to later extract common code into a separate repo that both
celestia-appandrollkitcan use.Changes needed to this code for use in rollkit will be handled in a later PR.
Also, extracts parts needed to resolve dependencies, specifically,
namespace,appconsts, and `testfactory.