added contexts to Celestia DataAvailabilityLayerClient#623
Merged
Conversation
tzdybal
reviewed
Nov 22, 2022
Co-authored-by: Tomasz Zdybał <tomek@zdybal.lap.pl>
Co-authored-by: Tomasz Zdybał <tomek@zdybal.lap.pl>
Co-authored-by: Tomasz Zdybał <tomek@zdybal.lap.pl>
Co-authored-by: Tomasz Zdybał <tomek@zdybal.lap.pl>
Co-authored-by: Tomasz Zdybał <tomek@zdybal.lap.pl>
Co-authored-by: Tomasz Zdybał <tomek@zdybal.lap.pl>
Codecov Report
@@ Coverage Diff @@
## main #623 +/- ##
==========================================
- Coverage 55.59% 55.46% -0.14%
==========================================
Files 50 50
Lines 10301 10301
==========================================
- Hits 5727 5713 -14
- Misses 3714 3723 +9
- Partials 860 865 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
S1nus
requested review from
Manav-Aggarwal,
Wondertan,
nashqueue and
tzdybal
tzdybal
suggested changes
Nov 30, 2022
Contributor
tzdybal
left a comment
tzdybal
left a comment
There was a problem hiding this comment.
One comment, but applies in multiple places - please rename variable from context to ctx.
nashqueue
suggested changes
Dec 5, 2022
tzdybal
reviewed
Dec 12, 2022
Contributor
tzdybal
left a comment
tzdybal
left a comment
There was a problem hiding this comment.
Looks good. I left small comment regarding tests. Please rebase.
tzdybal
reviewed
Dec 14, 2022
nashqueue
approved these changes
Dec 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Adding
Contextparameters to theCheckBlockAvailability,SubmitBlock, andRetrieveBlocksfunctions of theDataAvailabilityLayerClientobject. Work-in-progress.Goal is to enable requests to be cancelled easily, or allow them to have deadlines.
Resolves #354.
Checklist