Conversation
tzdybal
force-pushed
the
tzdybal/addr_conversion
branch
from
611ba4d to
40d3c2f
Compare
tzdybal
force-pushed
the
tzdybal/blockstore
branch
from
99a1705 to
2ad7280
Compare
tzdybal
force-pushed
the
tzdybal/blockstore
branch
from
2ad7280 to
d93c7ba
Compare
tzdybal
requested review from
Wondertan and
liamsi
and removed request for
Wondertan
tzdybal
force-pushed
the
tzdybal/blockstore
branch
from
622366d to
2f19fd6
Compare
| func TestBootstrapping(t *testing.T) { | ||
| log.SetLogLevel("dht", "INFO") | ||
| _ = log.SetLogLevel("dht", "INFO") | ||
| //log.SetDebugLogging() |
There was a problem hiding this comment.
I am not sure if we need to keep that logging/debugging code in master actually. I usually remove that code before merging and put it back for local usage only without committing
| } | ||
|
|
||
| func (bs *DefaultBlockStore) SaveBlock(block *types.Block) error { | ||
| // TODO(tzdybal): proper serialization & hashing |
There was a problem hiding this comment.
Why not make it proper already?
If we building things from scratch here, sticking with easy and performant solutions like sha256-simd from the beginning makes sense.
There was a problem hiding this comment.
Goal of this PR is to introduce block store that works. Using sha256-simd actually makes sense as it's drop-in replacement. By this comment I mostly mean that the serialization and hashing code will definitely be modified in the future.
That is not specified yet. It will be different from lazyledger-core for sure. If you want to write an ADR for that, that would be more than welcome. But remember that after an aggregator proposes a block, its data will also be available on LL and can be downloaded by anyone once this feature lands: https://github.com/lazyledger/lazyledger-core/issues/221 (cc @Wondertan). |
| // TODO(tzdybal): any better way to convert slice to array? | ||
| var h [32]byte | ||
| copy(h[:], hash) |
There was a problem hiding this comment.
I think that is the most common way. You could add a helper method (or methods) if you have to convert back and forth.
| return &block, nil | ||
| } | ||
|
|
||
| // TODO(tzdybal): replace with proper hashing mechanism |
There was a problem hiding this comment.
It would be good to decide on all cryptographic primitives in ADR I think.
| getRandomBlock(4, 100), | ||
| getRandomBlock(5, 10), | ||
| getRandomBlock(1, 10), | ||
| }}, |
3 participants
This PR introduces Block store.
Depends on: #40, #41.