refactor: use errors.New to replace fmt.Errorf with no parameters

[LesCyber]

unify the error handling methods that are different from the project style

Summary by CodeRabbit

• Refactor
  • Streamlined error handling across several system components to ensure consistent and simplified error messaging.
  • Standardized error reporting, which supports easier troubleshooting and better maintainability.
  • While the displayed error texts remain unchanged for users, these improvements enhance internal clarity and set the stage for more robust system monitoring.

[coderabbitai]

Walkthrough

The pull request updates error instantiation across several files by replacing instances of fmt.Errorf with errors.New. The changes occur in error messages within functions of the sync service, node command execution, full node initialization, full client methods, and block execution, without altering the underlying control flow or functionality of the application.

Changes

File(s)	Change Summary
block/sync_service.go, cmd/rollkit/commands/run_node.go	Replaced fmt.Errorf with errors.New in methods responsible for starting the syncer and executing node commands, streamlining error creation.
node/full.go, state/executor.go	Updated error handling in functions (initDALC and ApplyBlock) by substituting formatted error creation with simple error instantiation via errors.New.
node/full_client.go	Modified error messages in the GenesisChunked, Validators, and Status methods to use errors.New instead of fmt.Errorf, simplifying the error reporting without affecting logic.

Possibly related PRs

• fix(executor): nil error is passed as %w to fmt.Errrof #1697: Involves similar changes to error handling in the ApplyBlock method of the BlockExecutor struct, indicating a directly related modification.

Suggested reviewers

• tzdybal
• gupadhyaya
• MSevey
• tuxcanfly

Poem

I’m a little rabbit, hopping through the code,
Swapping fancy fmt errors to a simpler error mode.
With each little change, my heart does a cheer,
Carrots in the garden, clarity drawing near.
In lines of code I prance, in fields so bright and free,
Celebrating clean errors—code hops in harmony!
🥕🌟

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0fbd148 and c65fe72.

📒 Files selected for processing (5)

• block/sync_service.go (2 hunks)
• cmd/rollkit/commands/run_node.go (1 hunks)
• node/full.go (1 hunks)
• node/full_client.go (3 hunks)
• state/executor.go (1 hunks)

✅ Files skipped from review due to trivial changes (1)

• node/full.go

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Summary

🔇 Additional comments (11)

cmd/rollkit/commands/run_node.go (2)

223-223: Appropriate use of errors.New() for static error string

This correctly replaces fmt.Errorf() with errors.New() since no string formatting is required.

---

226-226: Appropriate use of errors.New() for static error string

This change correctly follows Go best practices by using errors.New() instead of fmt.Errorf() for error messages without any formatted values.

state/executor.go (1)

217-217: Error handling improvement using errors.New

Good replacement of fmt.Errorf() with errors.New() for a static error message with no formatting needed.

node/full_client.go (4)

289-289: Proper use of errors.New for static error message

This change correctly replaces fmt.Errorf() with errors.New() since the error message doesn't require any string formatting.

---

294-294: Appropriate use of errors.New

The change correctly uses errors.New() instead of fmt.Errorf() for a static error message.

---

529-529: Simplified error creation with errors.New

Good improvement - using errors.New() is more appropriate here since no string formatting is needed.

---

743-743: Consistent error handling with errors.New

This change maintains consistency with the other error handling improvements in the file.

block/sync_service.go (4)

111-111: Improved error handling with errors.New

Correctly uses errors.New() instead of fmt.Errorf() for a static error message that doesn't require formatting.

---

126-126: Appropriate use of errors.New for static error

Good change replacing fmt.Errorf() with errors.New() for a non-formatted error message.

---

132-132: Simplified error creation

This change appropriately uses errors.New() for a static error message.

---

140-140: Consistent error handling improvement

Good use of errors.New() for a static error message, maintaining consistency with the project's error handling style.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 41.95%. Comparing base (0fbd148) to head (c65fe72).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
block/sync_service.go	0.00%	4 Missing ⚠️
node/full_client.go	0.00%	4 Missing ⚠️
cmd/rollkit/commands/run_node.go	0.00%	2 Missing ⚠️
node/full.go	0.00%	1 Missing ⚠️
state/executor.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2023      +/-   ##
==========================================
- Coverage   42.05%   41.95%   -0.10%     
==========================================
  Files          80       80              
  Lines       12958    12958              
==========================================
- Hits         5449     5437      -12     
- Misses       6783     6793      +10     
- Partials      726      728       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.