added postgres adapter#8
Merged
eser merged 1 commit intoeser:developmentfrom Dec 3, 2022
wralith:add-pg-adapter
Merged
Conversation
eser
approved these changes
Dec 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature: This PR adds postgres adapter for
src/lib/dataUnimplemented Methods
find()andfindAll(): I need more instruction on how you want them to work. Maybe additional type with filter conditions.Behaviors
add,updateandreplacethrows if param type does not match with table.Assumptions
Talready created in the database.idIntroduced Dependencies
deno-postgresdriver handling connection between code and database.bldI couldn't find compatible query builder to use withdeno-postgresand wrote simple one. Can be replaced if there are alternative to implement queries with generic data type.Tests