Document supported async libraries#387
Merged
florimondmanca merged 2 commits intomasterfrom Sep 26, 2019
Merged
Conversation
sethmlarson
approved these changes
Sep 25, 2019
Contributor
sethmlarson
left a comment
sethmlarson
left a comment
There was a problem hiding this comment.
This looks good to me. 👍 For me it definitely solidifies the idea that we should be auto-detecting which async library, but that's something for another day!
florimondmanca
force-pushed
the
doc/async-libraries
branch
from
540901a to
7a706ed
Compare
Contributor
Author
|
@sethmlarson I added an extra admonition with installation instructions for trio; I think your comment (which it seems you removed?) was relevant. |
Contributor
|
Eh, I'm wondering if it's needed cuz it's not possible to run trio without trio installed. |
Contributor
Author
|
Yeah, fair point. Does that mean we don't actually need the |
Contributor
|
Probably not! |
Merged
florimondmanca
force-pushed
the
doc/async-libraries
branch
from
7a706ed to
c4d3739
Compare
florimondmanca
force-pushed
the
doc/async-libraries
branch
from
c4d3739 to
c3425c5
Compare
pquentin
reviewed
Sep 26, 2019
sethmlarson
approved these changes
Sep 26, 2019
Contributor
sethmlarson
left a comment
sethmlarson
left a comment
There was a problem hiding this comment.
Looks great, thanks yall!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the addition of trio support via #276.