Add server.url property in tests#300
Merged
florimondmanca merged 2 commits intoencode:masterfrom Sep 1, 2019
Merged
Conversation
theruziev
force-pushed
the
server_url_test
branch
from
36f628f to
3c8998d
Compare
florimondmanca
suggested changes
Aug 31, 2019
tests/conftest.py
Outdated
| @property | ||
| def url(self) -> URL: | ||
| protocol = "https" if self.config.is_ssl else "http" | ||
| return URL(f"{protocol}://{self.config.host}:{self.config.port}/") |
Contributor
There was a problem hiding this comment.
Just a nit: could we consider placing this property at the top of the class? The serve(), restart() and watch_restarts() methods are all kind of related in a non-immediately obvious way, so I think it's best to keep them together.
sethmlarson
approved these changes
Sep 1, 2019
Contributor
sethmlarson
left a comment
sethmlarson
left a comment
There was a problem hiding this comment.
What an awesome first contribution!!! Thanks so much :) Everything looks great to me. I'll leave this for you @florimondmanca to merge when ready.
sethmlarson
changed the title
florimondmanca
approved these changes
Sep 1, 2019
Contributor
florimondmanca
left a comment
florimondmanca
left a comment
There was a problem hiding this comment.
Fab! Thank you @theruziev!
Contributor
|
Good stuff! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #288