fix: use the lineWidth option for line breaking in flow collections#522
Merged
eemeli merged 1 commit intoeemeli:mainfrom Feb 15, 2024
Merged
fix: use the lineWidth option for line breaking in flow collections#522eemeli merged 1 commit intoeemeli:mainfrom
lineWidth option for line breaking in flow collections#522eemeli merged 1 commit intoeemeli:mainfrom
Conversation
eemeli
requested changes
Feb 13, 2024
Owner
eemeli
left a comment
eemeli
left a comment
There was a problem hiding this comment.
Looks promising! Should include an additional test or three to exercise the option. Also, see inline comment.
This should address issues eemeli#288 and eemeli#507.
no92
force-pushed
the
line-breaking-fix
branch
from
ad763fd to
2ce67c7
Compare
Contributor
Author
|
I also amended the commit to include two testcases, with one that wraps and another test that does not. |
eemeli
approved these changes
Feb 15, 2024
eemeli
added a commit
that referenced
this pull request
Jul 7, 2024
This was referenced Sep 13, 2024
This was referenced Sep 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should address issues #288 and #507.