Skip to content

Fix malformed uri#498

Merged
eemeli merged 4 commits intoeemeli:mainfrom
manunio:fix-malformed-uri
Oct 14, 2023
Merged

Fix malformed uri#498
eemeli merged 4 commits intoeemeli:mainfrom
manunio:fix-malformed-uri

Conversation

@manunio
Copy link
Contributor

@manunio manunio commented Oct 13, 2023

While Fuzzing locally using jazzer.js YAML.parse() threw uncaught exception at

if (prefix) return prefix + decodeURIComponent(suffix)
this pr attempts to fix that.

URIError: URI malformed
    at decodeURIComponent (<anonymous>)
    at Directives.tagName (/home/maxx/dev/security/oss-fuzz-projects/eemeli-yaml/dist/doc/directives.js:126:29)

Copy link
Owner

@eemeli eemeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for reporting this! In general the fix looks right, but see line comments for details.

@manunio manunio requested a review from eemeli October 13, 2023 18:14
Copy link
Owner

@eemeli eemeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I realised that there's a better place for the test, so I moved it there.

@eemeli eemeli merged commit 69d881c into eemeli:main Oct 14, 2023
@manunio manunio deleted the fix-malformed-uri branch October 14, 2023 08:34
This was referenced Sep 13, 2024
This was referenced Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants