Uses assert_called_with instead of called_with#2375
Merged
wbarnha merged 1 commit intodpkp:masterfrom Nov 3, 2023
Merged
Conversation
Contributor
|
I'll revisit this as soon as #2378 is merged. |
wbarnha
approved these changes
Nov 3, 2023
Contributor
Author
|
@wbarnha Thanks for your works! |
bradenneal1
pushed a commit
to bradenneal1/kafka-python
that referenced
this pull request
May 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, Please check my patch. In my environment of Python3.12, an error occurs at the following line. Here is a part of the error message.
Two assertions exists at the above line. The first assertion
called_withis called and thenassertis called. At the first assertion, we should seem to useassert_called_withinstead ofcalled_with. Please see:python/cpython#100690
Then, the arguments of
assert_called_withshould berequest, blocking=FalsebecauseKafkaClientinternally callssendwith them.https://github.com/dpkp/kafka-python/blob/master/kafka/client_async.py#L539
The second assertion should be removed because
assertraises an error when an assert statement fails and do nothing when the statement succeeds.Thanks in advance,
Hirotaka
This change is