remove examples for ENV key value without '='#11414
remove examples for ENV key value without '='#11414usha-mandya merged 1 commit intodocker:masterfrom
Conversation
|
Need to verify if the code-hint changes/indentation is right, so waiting for Netlify preview |
|
Deploy preview for docsdocker ready! Built with commit f6adc80 |
compose/django.md
Outdated
| ```none | ||
| version: '3' | ||
| ```yaml | ||
| version: "{{ site.compose_file_v3 }}" |
There was a problem hiding this comment.
Hmm.. this somehow adds a space in front of each line. I recall we had a similar issue at some point; #8105 (also somewhere else, but trying to find what the solution was for that)
thaJeztah
force-pushed
the
bare_env_examples
branch
5 times, most recently
from
7b8b8ba to
8ad9c52
Compare
The `ENV key value` form can be ambiguous, for example, the following defines
a single env-variable (`ONE`) with value `"TWO= THREE=world"`:
ENV ONE TWO= THREE=world
While we cannot deprecate/remove that syntax (as it would break existing
Dockerfiles), we should reduce exposure of the format in our examples.
Also updating some code-blocks that were missing language-hints
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
bare_env_examples
branch
from
8ad9c52 to
f6adc80
Compare
|
ok, fixed the indentation, this should be ready for review. To view without the indentation changes, use this link: https://github.com/docker/docker.github.io/pull/11414/files?w=1 @usha-mandya ptal |
|
Thanks @thaJeztah Good to know that. I try to create PR's in the extension and their docs to move to |
|
Good catch, thanks @StefanScherer ! |
|
Thank you @StefanScherer @thaJeztah |
|
I also created microsoft/vscode-docs#4024 in the vscode docs repo. |
3 participants
The
ENV key valueform can be ambiguous, for example, the following defines a single env-variable (ONE) with value"TWO= THREE=world":While we cannot deprecate/remove that syntax (as it would break existing Dockerfiles), we should reduce exposure of the format in our examples.
Also updating some code-blocks that were missing language-hints
Related issues (optional)
relates to moby/buildkit#1692 (comment), docker/cli#2741