cli/command/container: create: assorted cleanups and linting fixes#6759
Merged
vvoland merged 5 commits intodocker:masterfrom Jan 26, 2026
Merged
cli/command/container: create: assorted cleanups and linting fixes#6759vvoland merged 5 commits intodocker:masterfrom
vvoland merged 5 commits intodocker:masterfrom
Conversation
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This was addressed in 7bdb4df Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added
status/2-code-review
kind/refactor
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
1 task
vvoland
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cli/command/container: rename vars to use correct camelCase
cli/command/container: copyDockerConfigIntoContainer: close TarWriter
cli/command/container: remove outdated TODO
This was addressed in 7bdb4df
cli/command/container: createContainer: remove redundant closure
cli/command/container: createContainer: remove intermediate vars
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)