Skip to content

cli-plugins/manager: use stdlib errors, and minor cleanup#5903

Merged
thaJeztah merged 1 commit intodocker:masterfrom
thaJeztah:cli_plugins_no_pkg_errors
Mar 10, 2025
Merged

cli-plugins/manager: use stdlib errors, and minor cleanup#5903
thaJeztah merged 1 commit intodocker:masterfrom
thaJeztah:cli_plugins_no_pkg_errors

Conversation

@thaJeztah
Copy link
Member

- What I did

- How I did it

- How to verify it

- Human readable description for the release notes

- A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah added status/2-code-review area/plugins kind/refactor PR's that refactor, or clean-up code labels Mar 7, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 59.26%. Comparing base (e201b4e) to head (8fc0c74).
Report is 34 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5903   +/-   ##
=======================================
  Coverage   59.26%   59.26%           
=======================================
  Files         357      357           
  Lines       29771    29771           
=======================================
  Hits        17645    17645           
  Misses      11153    11153           
  Partials      973      973           
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@thaJeztah
Copy link
Member Author

Hm.. did I break something? Last PR was happy :thinking_face:

=== Failed
=== FAIL: e2e/plugin TestInstallWithContentTrust (4.27s)
    trust_test.go:40: assertion failed: 
        Command:  docker plugin push registry:5000/plugin-content-trust
        ExitCode: 1
        Error:    exit status 1
        Stdout:   The push refers to repository [registry:5000/plugin-content-trust]
        073f57518a8b: Preparing
        dae68ee65fc3: Preparing
        51df3a2ed0d0: Preparing
        073f57518a8b: Preparing
        dae68ee65fc3: Preparing
        51df3a2ed0d0: Preparing
        
        Stderr:   error pushing plugin: failed to do request: Head "https://registry:5000/v2/plugin-content-trust/blobs/sha256:dae68ee65fc39a8460c91e29347bfaf09e2c71df6329aa37a0946cfd6b8492a6": http: server gave HTTP response to HTTPS client
        
        
        Failures:
        ExitCode was 1 expected 0
        Expected stdout to contain "Signing and pushing trust metadata"
        Expected no error

@thaJeztah thaJeztah marked this pull request as ready for review March 8, 2025 15:56
@thaJeztah thaJeztah requested review from Benehiko and vvoland March 10, 2025 16:49
@thaJeztah thaJeztah merged commit 29c1aba into docker:master Mar 10, 2025
107 checks passed
@thaJeztah thaJeztah deleted the cli_plugins_no_pkg_errors branch March 10, 2025 17:03
@thaJeztah thaJeztah added this to the 28.0.2 milestone Mar 10, 2025
@thaJeztah thaJeztah self-assigned this May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/plugins kind/refactor PR's that refactor, or clean-up code status/2-code-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants