Bash completion for docker context command family#1619
Merged
thaJeztah merged 2 commits intodocker:masterfrom Jan 29, 2019
Merged
Bash completion for docker context command family#1619thaJeztah merged 2 commits intodocker:masterfrom
docker context command family#1619thaJeztah merged 2 commits intodocker:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1619 +/- ##
=======================================
Coverage 55.16% 55.16%
=======================================
Files 301 301
Lines 20384 20384
=======================================
Hits 11244 11244
Misses 8335 8335
Partials 805 805 |
albers
force-pushed
the
completion-context
branch
from
1c49fe6 to
f2cb76d
Compare
albers
force-pushed
the
completion-context
branch
from
ae0e647 to
4b92f12
Compare
Signed-off-by: Harald Albers <github@albersweb.de>
albers
force-pushed
the
completion-context
branch
from
fa93b62 to
41bd8da
Compare
albers
changed the title
docker context command familydocker context command family
Contributor
simonferquel
left a comment
simonferquel
left a comment
There was a problem hiding this comment.
Please also note the --context (or -c) global flag. It should have a similar impact as --host on other completion scripts (list of containers, images etc.)
Otherwise seems good to me :)
Signed-off-by: Harald Albers <github@albersweb.de>
Collaborator
Author
|
@simonferquel Done.
|
Contributor
|
That seems good, I can't test it right now though :/ ping @vdemeester or @thaJeztah |
silvin-lubecki
approved these changes
Jan 23, 2019
Contributor
silvin-lubecki
left a comment
silvin-lubecki
left a comment
There was a problem hiding this comment.
I'm not a shell completion expert at all, but as far as I can tell, it looks good to me 👍
vdemeester
approved these changes
Jan 23, 2019
Collaborator
vdemeester
left a comment
vdemeester
left a comment
There was a problem hiding this comment.
LGTM 🐯
/cc @thaJeztah
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #1501