Skip to content

bake: x-bake extension field with compose#721

Merged
tonistiigi merged 1 commit intodocker:masterfrom
crazy-max:compose-ext
Aug 13, 2021
Merged

bake: x-bake extension field with compose#721
tonistiigi merged 1 commit intodocker:masterfrom
crazy-max:compose-ext

Conversation

@crazy-max
Copy link
Member

@crazy-max crazy-max commented Aug 8, 2021

Ref. compose-spec/compose-spec#120 #183 (comment)

Might also need to update the compose-cli build options to handle x-bake in a follow-up.

cc @chris-crone

Signed-off-by: CrazyMax crazy-max@users.noreply.github.com

@crazy-max crazy-max added area/bake kind/enhancement New feature or request labels Aug 8, 2021
@crazy-max crazy-max marked this pull request as ready for review August 10, 2021 17:40
@tonistiigi
Copy link
Member

Tags should be read from regular service tags. Cache-from also already exists.

@crazy-max
Copy link
Member Author

crazy-max commented Aug 11, 2021

@tonistiigi

Tags should be read from regular service tags.

Tags are only handled as a single value through image field in compose afaik, that's why it's available as an extension here.

Cache-from also already exists.

Ah yes cache_from is available in the compose v2 spec.

@crazy-max crazy-max force-pushed the compose-ext branch 5 times, most recently from d80fb2a to d847418 Compare August 11, 2021 13:12
@dudicoco
Copy link

@tonistiigi

Tags should be read from regular service tags.

Tags are only handled as a single value through image field in compose afaik, that's why it's available as an extension here.

Cache-from also already exists.

Ah yes cache_from is available in the compose v2 spec.

Correct me if i'm wrong, but I believe the compose spec cache_from doesn't support all of the buildx cache features such as cache from local.

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/bake kind/enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants