Merged
Conversation
…ction that returns a new undom() factory with new prototypes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds on #24. In #24, DOM classes/prototypes became shared across all Documents created via
undom():With this PR,
undom()continues to return shared constructors. However, a newundom.env()method returns a new factory function (akin toundom()) that can be called to create documents with a new set of constructors:This means we still encourage using the shared globals, but allow creating a new set of them if necessary.
It also opens up an interesting option for plugins, which were proposed a while ago, but would have been difficult to implement.