added some details to README#31
Merged
debugger22 merged 1 commit intodebugger22:masterfrom Oct 21, 2016
Merged
Conversation
debugger22
reviewed
Oct 21, 2016
| This application requires: | ||
| * node | ||
| * npm | ||
| * redix |
Owner
|
Thanks for taking it up! |
debugger22
added a commit
that referenced
this pull request
Jan 18, 2023
added some details to README
debugger22
added a commit
that referenced
this pull request
Jan 18, 2023
added some details to README
debugger22
added a commit
that referenced
this pull request
Jan 18, 2023
added some details to README
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nice work on this cool project.
I came across your project because of other people's forks on Hacktober best.
I thought I start contributing by adding some contents to README.md to document the process of running this app better.
I also ran into some problems in the client side for socketio connection. After some stack overflow, I made one minor change that ran the app for me:
http://stackoverflow.com/questions/24526166/socketio-err-connection-refused
Hopefully you accept my pull request (PR) and let me know some things you like to see.
I personally would like to make this ES6 compatible, and some areas of the code could use a bit more documentation, like the server code. We can make the client accept other API's too.