fix manager role in admin users overview#5359
Merged
BlackDex merged 1 commit intodani-garcia:mainfrom Jan 7, 2025
Merged
Conversation
due to the hack the returned type has changed
Collaborator
|
Hmmm, it might also cause issues with the feature to adjust the user status, but not sure. |
Collaborator
|
That seems to still work fine. It might be an option to set |
BlackDex
approved these changes
Jan 7, 2025
Contributor
Author
|
Yeah. I mean I have not tested this extensively (what happens if I change a User to Manager via /admin, etc.) but without this change there will be an exception raised and no scripts will run. That's how I found it because it was impossible to delete a invited user via /admin interface. |
Collaborator
|
I tested it, and it seems to work just fine :) |
dfunkt
pushed a commit
to dfunkt/vaultwarden
that referenced
this pull request
Jan 7, 2025
due to the hack the returned type has changed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
due to this hack the returned type in the overview has changed:
vaultwarden/src/db/models/organization.rs
Lines 383 to 385 in ef4bff0