Fix notes due to TBAA and use "implementation" instead of "compiler"#4773
Closed
frederick-vs-ja wants to merge 11 commits intocplusplus:mainfrom
Closed
Fix notes due to TBAA and use "implementation" instead of "compiler"#4773frederick-vs-ja wants to merge 11 commits intocplusplus:mainfrom
frederick-vs-ja wants to merge 11 commits intocplusplus:mainfrom
Conversation
…4732) A new note explains that `emplace-deref` does not require materialization of the result of `*i` before the initialization. The normatively expressed requirement in terms of an invented initialization of a variable was prone to confusion, since such a declaration would indeed require `*i` to be copyable/movable, whereas the actual use of `emplace-deref` does not cause any intermediate materializations of prvalues.
…his object" Avoid saying "this object" when not talking about `*this`.
…re accurately Class templates are not types. Function templates are not function signatures.
The definition of 'common initial sequence' in [class.mem] only applies to standard-layout struct types, which excludes unions. There is no reason to define is_corresponding_member in terms of standard-layout types (which includes unions and scalars and arrays of such types) when the common initial sequence is only meaningful for standard-layout structs.
The former includes names introduced by alias-declarations, the latter (arguably) does not.
Contributor
|
Could you kindly rebase this? I had to force-push the main branch. Thanks! |
jensmaurer
added
the
needs rebase
frederick-vs-ja
force-pushed
the
patch-1
branch
2 times, most recently
from
5ad5d38 to
7a2f9b6
Compare
Member
|
@frederick-vs-ja , we're sorry, but this seems to need another rebase / force-push. Please do not create merge commits; just rebase, fix the fall-out and force-push. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4701.
I'm not sure whether the "compiler" in "compiler optimization", "compiler transformation" etc. can be replaced with "implementation".