windows build fix, part 1, stdint#2
Closed
pierrejoye wants to merge 3 commits intocouchbase:masterfrom
Closed
Conversation
Contributor
Author
|
Added the missing E* too |
Contributor
|
This was integrated over through http://review.couchbase.com |
Member
|
And could be found at http://review.couchbase.org/13387 |
mnunberg
referenced
this pull request
in mnunberg/libcouchbase
Feb 1, 2014
Change-Id: Ida0e4768bd300a4f11a09c8c66a2dbb062f7ff01
ns-codereview
pushed a commit
that referenced
this pull request
Sep 8, 2017
* Direct leak of 128 byte(s) in 5 object(s) allocated from:
#0 0x4f7ef0 in __interceptor_malloc (libcouchbase/build/bin/check-all+0x4f7ef0)
#1 0x54d99e in parse_value libcouchbase/contrib/cliopts/cliopts.c:290:20
#2 0x54b7f3 in cliopts_parse_options libcouchbase/contrib/cliopts/cliopts.c:785:23
#3 0x53c3c3 in cliopts::Parser::parse(int, char**, bool) libcouchbase/contrib/cliopts/cliopts.h:554:18
#4 0x538b5f in TestConfiguration::parseOptions(int, char**) libcouchbase/tests/check-all.cc:162:21
#5 0x536345 in main libcouchbase/tests/check-all.cc:581:17
#6 0x7f3730322509 in __libc_start_main /usr/src/debug/glibc-2.25-49-gbc5ace67fe/csu/../csu/libc-start.c:295
Change-Id: I72ac325b515525450030d458c056f65b42ca138a
Reviewed-on: http://review.couchbase.org/83142
Reviewed-by: Matt Ingenthron <matt@couchbase.com>
Tested-by: Build Bot <build@couchbase.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I slightly improved the test for stdint to limit it to windows only
Also libcouchbase needs a check for stdint in configure as well and fall back to manually defined types if not present.
There are other builds issues left (testing with VC9 + SDK 6.1, used by PHP builds) related to the socket error codes.