avoid import to testing pkg outside of tests#11666
Merged
estesp merged 1 commit intocontainerd:mainfrom Apr 8, 2025
Merged
Conversation
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
|
Skipping CI for Draft Pull Request. |
Member
|
Looks like this was originally done this way for fuzz. However the fuzz code moved to test so this is good . |
dmcgowan
approved these changes
Apr 8, 2025
estesp
approved these changes
Apr 8, 2025
ghost
reviewed
Apr 24, 2025
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Member
|
/cherry-pick release/2.0 |
|
@austinvazquez: new pull request created: #11833 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go deadcode removal is not very smart, especially if other code that imports this pkg uses
reflect.Leaving draft as there is another import via vendor containerd/go-cni#128 . Lmk if you like this in anyway. Eg. buildx does not have imports to
go-cniso is only affected by this one.