Skip to content

avoid import to testing pkg outside of tests#11666

Merged
estesp merged 1 commit intocontainerd:mainfrom
tonistiigi:remove-testing-import
Apr 8, 2025
Merged

avoid import to testing pkg outside of tests#11666
estesp merged 1 commit intocontainerd:mainfrom
tonistiigi:remove-testing-import

Conversation

@tonistiigi
Copy link
Member

Go deadcode removal is not very smart, especially if other code that imports this pkg uses reflect.

Leaving draft as there is another import via vendor containerd/go-cni#128 . Lmk if you like this in anyway. Eg. buildx does not have imports to go-cni so is only affected by this one.

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
@k8s-ci-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@dmcgowan
Copy link
Member

dmcgowan commented Apr 8, 2025

Looks like this was originally done this way for fuzz. However the fuzz code moved to test so this is good .

@tonistiigi tonistiigi marked this pull request as ready for review April 8, 2025 18:59
@dmcgowan dmcgowan added the cherry-pick/2.0.x Change to be cherry picked to release/2.0 branch label Apr 8, 2025
@github-project-automation github-project-automation bot moved this from Needs Triage to Review In Progress in Pull Request Review Apr 8, 2025
@estesp estesp added this pull request to the merge queue Apr 8, 2025
Merged via the queue into containerd:main with commit 6fa7440 Apr 8, 2025
58 checks passed
@github-project-automation github-project-automation bot moved this from Review In Progress to Done in Pull Request Review Apr 8, 2025
ghost

This comment was marked as off-topic.

This comment was marked as off-topic.

@austinvazquez
Copy link
Member

/cherry-pick release/2.0

@k8s-infra-cherrypick-robot

@austinvazquez: new pull request created: #11833

Details

In response to this:

/cherry-pick release/2.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@austinvazquez austinvazquez added cherry-picked/2.0.x PR commits are cherry picked into the release/2.0 branch and removed cherry-pick/2.0.x Change to be cherry picked to release/2.0 branch labels May 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-picked/2.0.x PR commits are cherry picked into the release/2.0 branch size/XS

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants