Stop emailing students & coaches without TOC accepted#1750
Merged
gnclmorais merged 2 commits intocodebar:masterfrom Oct 26, 2024
Merged
Stop emailing students & coaches without TOC accepted#1750gnclmorais merged 2 commits intocodebar:masterfrom
gnclmorais merged 2 commits intocodebar:masterfrom
Conversation
Contributor
Author
|
I kind of want to raise again that our parameters for Code Climate feel a bit high… The issues raised feel a bit overzealous. |
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Closing as stale. |
Contributor
|
@gnclmorais was this PR ever finished? I think it would be still worth implementing this so I'm reopening the PR. |
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
After talking with Kim about this a few weeks ago, we realised it doesn’t make much sense to email members that have not accepted our terms about new events. We see that as not having come back to codebar in a while, thus making more sense to save our resources.
gnclmorais
force-pushed
the
dont-email-unaccepted-toc
branch
from
eb35954 to
6393804
Compare
matyikriszta
approved these changes
Oct 26, 2024
Contributor
matyikriszta
left a comment
matyikriszta
left a comment
There was a problem hiding this comment.
Nice one 🎉, thanks @gnclmorais
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After talking with Kim about this a few weeks ago, we realised it doesn’t make much sense to email members that have not accepted our terms about new events. We see that as not having come back to codebar in a while, thus making more sense to save our resources.