feat(clerk-js): Reuse SignIn/SignUp instances #7803
+104
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the Client JSON parsing logic to reuse existing
SignInandSignUpinstances when the incoming IDs match the current instance. This results in a stable referential identity forclient.signInandclient.signUpwhen possible. Previously, we were creating new instances ofSignIn/SignUpon every request: one from the mutation HTTP request response, and another from the client piggybacking response. This caused two update events to be emitted, each with different instances of the class.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
Summary by CodeRabbit