Skip to content

Drop support for ruby 2.2#41

Merged
nijikon merged 3 commits intomasterfrom
drop-support-for-ruby-2.2
Jan 19, 2019
Merged

Drop support for ruby 2.2#41
nijikon merged 3 commits intomasterfrom
drop-support-for-ruby-2.2

Conversation

@nijikon
Copy link
Contributor

@nijikon nijikon commented Sep 23, 2018

@nijikon nijikon self-assigned this Sep 23, 2018
@nijikon nijikon requested review from btoews and wallin September 23, 2018 16:17
@btoews
Copy link

btoews commented Sep 24, 2018

Is the main argument for dropping support for 2.2 that we can remove the explicit String#freeze calls, or is the goal just to stay updated with support for the language?

@nijikon
Copy link
Contributor Author

nijikon commented Sep 24, 2018

I would say both, plus we should not encourage people to run outdated ruby versions. They will still be able to run the last version that supports 2.2 if needed.

@btoews
Copy link

btoews commented Sep 24, 2018

My inclination would be to not remove support for old Ruby versions without a compelling reason. I, for example, wouldn't want to force someone running Ruby 2.2 to update their Ruby version before being able to update this library for a security fix. People should be running supported versions of Ruby, but I don't think it's this library's job to convince them of that.

@nijikon
Copy link
Contributor Author

nijikon commented Oct 14, 2018

We won't force anybody to upgrade, that's not my intention here. We can do a major bump after dropping support and if anything needs to be backported it can.

@nijikon
Copy link
Contributor Author

nijikon commented Jan 4, 2019

Bumping this again, I still think that we should drop support for version < 2.3, recently bundler did that and community is following that trend. People can always use the older version which supports 2.2 version.

@nijikon nijikon force-pushed the drop-support-for-ruby-2.2 branch from 101c9d5 to 58eed68 Compare January 5, 2019 14:07
@nijikon nijikon changed the base branch from API_v1_1 to master January 5, 2019 14:07
@nijikon
Copy link
Contributor Author

nijikon commented Jan 5, 2019

@mastahyeti ping

@btoews
Copy link

btoews commented Jan 7, 2019

I still don't see the benefit of removing support for older versions of Ruby. Maybe if there was a lot of active development on the repository and missing language features were a major annoyance to contributors. But, the U2F protocol itself is deprecated and I don't foresee a lot of activity on this repository moving forward. Removing support for old Ruby versions just for the sake of doing it doesn't seem compelling to me. This isn't my repo though and the @castle folks might feel differently.

@nijikon
Copy link
Contributor Author

nijikon commented Jan 19, 2019

People can always disagree and it's fine. I'm part of @castle team and we will be dropping support for 2.2 as we want to have this repository up-to-date.

@nijikon nijikon merged commit 4abd28d into master Jan 19, 2019
@nijikon nijikon deleted the drop-support-for-ruby-2.2 branch January 19, 2019 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants