Conversation
|
Is the main argument for dropping support for 2.2 that we can remove the explicit |
|
I would say both, plus we should not encourage people to run outdated ruby versions. They will still be able to run the last version that supports 2.2 if needed. |
|
My inclination would be to not remove support for old Ruby versions without a compelling reason. I, for example, wouldn't want to force someone running Ruby 2.2 to update their Ruby version before being able to update this library for a security fix. People should be running supported versions of Ruby, but I don't think it's this library's job to convince them of that. |
|
We won't force anybody to upgrade, that's not my intention here. We can do a major bump after dropping support and if anything needs to be backported it can. |
|
Bumping this again, I still think that we should drop support for version |
101c9d5 to
58eed68
Compare
|
@mastahyeti ping |
|
I still don't see the benefit of removing support for older versions of Ruby. Maybe if there was a lot of active development on the repository and missing language features were a major annoyance to contributors. But, the U2F protocol itself is deprecated and I don't foresee a lot of activity on this repository moving forward. Removing support for old Ruby versions just for the sake of doing it doesn't seem compelling to me. This isn't my repo though and the @castle folks might feel differently. |
|
People can always disagree and it's fine. I'm part of @castle team and we will be dropping support for 2.2 as we want to have this repository up-to-date. |
Support for ruby 2.2 ended on March 31, 2018.
https://www.ruby-lang.org/en/news/2018/06/20/support-of-ruby-2-2-has-ended/