Skip to content

Release (2) #1699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
renejeglinsky merged 1 commit into from
Mar 11, 2025
Merged

Release (2) #1699

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/cds-lint/components/PlaygroundBadge.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ function link(name: Props['name'] = "", kind: Props['kind'], rules?: Props['rule
if (files) {
for (const file of files) {
sources[file] = data[`${name}/${kind}/${file}`]
?.replace(/\/\/\s*\[!code.*?\]/g, ''); // remove Vitepress code comments
?.replace(/\/?\/?\s*\[!code.*?\]/g, ''); // remove Vitepress code comments
}
}
return `https://eslint-online-playground.netlify.app/#${compress(sources)}`
Expand Down
2 changes: 1 addition & 1 deletion tools/cds-lint/examples/no-dollar-prefixed-names/incorrect/db/schema.cds
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ entity Books {
key ID : Integer;
@mandatory title : localized String(111);
@mandatory author : Association to Authors;
$pages: Integer; // [!code error] // elements should not start with a dollar sign ($)
$pages: Integer; // elements should not start with a dollar sign ($) [!code error]
}

entity Authors {
Expand Down
2 changes: 1 addition & 1 deletion tools/cds-lint/examples/valid-csv-header/incorrect/db/data/sap.capire.bookshop-Books.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
ID;tile;author_ID // [!code warning]
ID;tile;author_ID
201;Wuthering Heights;101
207;Jane Eyre;107
2 changes: 1 addition & 1 deletion tools/cds-lint/rules/valid-csv-header.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ The following example shows a correct CSV file header that matches the column na
In the next example, there's a typo in the header of the CSV file. The column name `title` is misspelled as `tile`, so the rule reports a warning:

::: code-group
<<< ../examples/valid-csv-header/incorrect/db/data/sap.capire.bookshop-Books.csv#snippet{csv:line-numbers} [db/data/sap.capire.bookshop-Books.csv]
<<< ../examples/valid-csv-header/incorrect/db/data/sap.capire.bookshop-Books.csv#snippet{csv:line-numbers{1}} [db/data/sap.capire.bookshop-Books.csv]
:::
<PlaygroundBadge
name="valid-csv-header"
Expand Down