Add LSP completion for CEL expressions#4358
Merged
stefanvanburen merged 1 commit intomainfrom Feb 27, 2026
Merged
Conversation
This adds contextual completion for CEL expressions for protovalidate, in the same spirit as our completion approach for protobuf. I strongly suggest reviewing this by also installing this branch locally and trying out the completion in the testcases, to see how it feels to use locally.
Contributor
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
emcfarlane
reviewed
Feb 27, 2026
emcfarlane
approved these changes
Feb 27, 2026
Contributor
emcfarlane
left a comment
emcfarlane
left a comment
There was a problem hiding this comment.
Works well! Went through and tested some simple completions. Minor issue: completions for in complete to a function call in(), should just be membership test (this in that).
Member
Author
cool, I will follow up with a fix for that. thanks for checking it out! |
stefanvanburen
added a commit
that referenced
this pull request
Feb 27, 2026
[Caught][1] by @emcfarlane in #4358. Fixes the issue and adds a test. [1]: #4358 (review)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds contextual completion for CEL expressions for protovalidate, in the same spirit as our completion approach for protobuf.
I strongly suggest reviewing this by also installing this branch locally and trying out the completion in the testcases, to see how it feels to use locally.