Ability to split a message if it's too big to send in one piece#14
Open
AlexanderYAPPO wants to merge 1 commit intobot-api:masterfrom
Open
Ability to split a message if it's too big to send in one piece#14AlexanderYAPPO wants to merge 1 commit intobot-api:masterfrom
AlexanderYAPPO wants to merge 1 commit intobot-api:masterfrom
Conversation
AlexanderYAPPO
commented
Mar 25, 2019
|
|
||
| "github.com/bot-api/telegram" | ||
| "github.com/m0sth8/httpmock" | ||
| "github.com/jarcoal/httpmock" |
Author
There was a problem hiding this comment.
I didn't find additional commits in m0sth8/httpmock fork so I decided to switch it to upstream because they have a very useful feature httpmock.GetTotalCallCount
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a message is larger than 4096 bytes telegram API doesn't accept it. I added an api call that split big messages like that to smaller pieces and them send them one by one. Every time we try to split the text by whitespace symbols if it's possible. Otherwise we simply cut a word as soon as it's size is greater than allowed size.