Optionally pass BIP388 policy to signtx#792
Open
Sjors wants to merge 3 commits intobitcoin-core:masterfrom
Open
Optionally pass BIP388 policy to signtx#792Sjors wants to merge 3 commits intobitcoin-core:masterfrom
Sjors wants to merge 3 commits intobitcoin-core:masterfrom
Conversation
Sjors
force-pushed
the
2025/07/policy-sign
branch
7 times, most recently
from
31a9714 to
dfd11e0
Compare
Member
Author
|
Coldcard CI failure is probably spurious. |
Sjors
force-pushed
the
2025/07/policy-sign
branch
from
dfd11e0 to
b53160a
Compare
Member
Author
|
Rebased after #795 landed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another step towards #785.
Usage:
First register a policy with #791, #647, MooSig or some other method.
Construct a PSBT.
And then try to sign it.
It's easiest to test this with just a single sig wallet. Using #791 you can easily register it and get an hmac (even though registration isn't mandatory).
If you want to try with MuSig, you'll need either #784 or use a Bitcoin Core branch with PSBTv2 support (bitcoin/bitcoin#21283). I still need to test both these approaches.
Strongly overlaps with #647, but this implements signing independent of registration.