fix(diagnostic): include config path and CWD in ConfigurationOutsideProject by mvanhorn · Pull Request #9488 · biomejs/biome

mvanhorn · 2026-03-15T15:38:11Z

Summary

The "Biome found a configuration file outside of the current working directory" diagnostic now includes the actual configuration file path and working directory. Previously the message had no dynamic content, leaving users with no actionable information to debug the issue.

Before:

Biome found a configuration file outside of the current working directory.

After:

Biome found the configuration file "/home/user/.config/biome.json" outside of the current working directory "/home/user/project".

Both CLI and LSP code paths are updated.

Fixes #9463

Test Plan

cargo check -p biome_lsp -p biome_cli passes
Diagnostic struct now takes config_path and working_directory fields

AI Assistance

This PR was written with AI assistance (Claude Code).

…roject The error message "Biome found a configuration file outside of the current working directory" now includes the actual configuration file path and the working directory. This gives users actionable information to debug the issue. Fixes biomejs#9463 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

changeset-bot · 2026-03-15T15:38:16Z

🦋 Changeset detected

Latest commit: adff44b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages

Name	Type
@biomejs/biome	Patch
@biomejs/cli-win32-x64	Patch
@biomejs/cli-win32-arm64	Patch
@biomejs/cli-darwin-x64	Patch
@biomejs/cli-darwin-arm64	Patch
@biomejs/cli-linux-x64	Patch
@biomejs/cli-linux-arm64	Patch
@biomejs/cli-linux-x64-musl	Patch
@biomejs/cli-linux-arm64-musl	Patch
@biomejs/wasm-web	Patch
@biomejs/wasm-bundler	Patch
@biomejs/wasm-nodejs	Patch
@biomejs/backend-jsonrpc	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2026-03-15T15:44:38Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 3992e1ab-2c75-4261-bd15-d9bd74adace0

📥 Commits

Reviewing files that changed from the base of the PR and between 19f3ec6 and adff44b.

📒 Files selected for processing (1)

crates/biome_cli/src/runner/mod.rs

Walkthrough

The PR expands the ConfigurationOutsideProject diagnostic to include two public fields, config_path: String and working_directory: String, and removes the Default derive. Call sites in the CLI runner and the LSP session now capture and supply the config file path (falling back to "<unknown>" when needed) and compute a working-directory string; control flow and public signatures remain unchanged. Diagnostic message text was updated to reference the new fields.

Possibly related PRs

feat(core): hidden files and config dirs #8663: Modifies the same ConfigurationOutsideProject diagnostic and related callsites in service/CLI/LSP, making it directly code-level related.
fix(lsp): fix incorrect project dir when configurationPath points to config outside of workspace #9392: Adjusts configuration-path representation (ConfigurationPathHint variants) and enriches diagnostics with config and working-directory details.
fix(core): custom lsp configuration #9049: Changes session configuration-loading logic and the diagnostics emitted for out-of-project configurations.

Suggested labels

A-Diagnostic

Suggested reviewers

ematipico
dyc3
arendjr

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: enhancing the ConfigurationOutsideProject diagnostic to include the config path and current working directory.
Description check	✅ Passed	The description clearly explains the improvement with before/after examples and references the fixed issue `#9463`, demonstrating how the diagnostic message now provides actionable debugging information.
Linked Issues check	✅ Passed	The PR fully addresses issue `#9463` requirements: config file path and working directory are now included in the diagnostic struct fields and message, making the diagnostic actionable for users.
Out of Scope Changes check	✅ Passed	All changes are scoped to the ConfigurationOutsideProject diagnostic implementation across CLI and LSP code paths, with a changelog entry. No unrelated modifications detected.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

📝 Coding Plan

Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Tip

CodeRabbit can generate a title for your PR based on the changes.

Add @coderabbitai placeholder anywhere in the title of your PR and CodeRabbit will replace it with a title based on the changes in the PR. You can change the placeholder by changing the reviews.auto_title_placeholder setting.

coderabbitai

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@crates/biome_cli/src/runner/mod.rs`:
- Around line 390-398: The diagnostic is showing the directory path instead of
the actual config file path; change the construction of config_path_str to use
the loaded config file path variable (rather than directory_path) and fall back
to "<unknown>" if that file path is missing, then pass that into
PrintDiagnostic::simple(&ConfigurationOutsideProject { config_path:
config_path_str, working_directory: working_dir.to_string() }). Locate where
config_path_str is built (currently from directory_path.as_ref().map(|p|
p.to_string()).unwrap_or_else(...)) and replace that expression with the actual
config file path variable (e.g., config_path or config_file) converted to
string.

In `@crates/biome_lsp/src/session.rs`:
- Around line 979-985: The logged working_directory is derived directly from
ConfigurationPathHint variants and can be incorrect for FromUser and
FromUserExternal; update the logic that computes working_directory in session.rs
to reuse the same resolution used later for the effective project base (extract
or call the shared helper that resolves the base path used for project loading)
so that working_directory reflects the actual resolved base (ensure the code
paths around where ConfigurationPathHint is matched and where the effective
project base is computed both use the same resolver or helper function).

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 7ec74a85-247b-49b4-9f2c-9658072e8986

📥 Commits

Reviewing files that changed from the base of the PR and between fe9ff6b and a9b974a.

📒 Files selected for processing (3)

crates/biome_cli/src/runner/mod.rs
crates/biome_lsp/src/session.rs
crates/biome_service/src/diagnostics.rs

crates/biome_cli/src/runner/mod.rs

crates/biome_lsp/src/session.rs

Show the actual configuration file path in the ConfigurationOutsideProject diagnostic instead of just the directory path. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

ematipico · 2026-03-16T06:35:44Z

crates/biome_cli/src/runner/mod.rs

+            let config_path_str = config_file_path
+                .as_ref()
+                .map(|p| p.to_string())
+                .unwrap_or_else(|| "<unknown>".to_string());


Suggested change

.unwrap_or_else(|| "<unknown>".to_string());

.unwrap_or("<unknown>".to_string());

Applied in 3d4d125.

ematipico · 2026-03-16T06:36:31Z

crates/biome_cli/src/runner/mod.rs

            &root_configuration_dir
        };
        if !loaded_location.is_in_project() {
+            let config_path_str = config_file_path


Suggested change

let config_path_str = config_file_path

let config_file_path = config_file_path

Applied in 3d4d125.

ematipico · 2026-03-16T06:36:51Z

crates/biome_cli/src/runner/mod.rs

            console.log(markup! {
-                {PrintDiagnostic::simple(&ConfigurationOutsideProject)}
+                {PrintDiagnostic::simple(&ConfigurationOutsideProject {
+                    config_path: config_path_str,


Suggested change

config_path: config_path_str,

config_path: config_file_path,

Applied in 3d4d125.

crates/biome_lsp/src/session.rs

- Apply ematipico's code suggestions: rename config_path_str to config_file_path, use unwrap_or, update struct field reference. - Fix LSP working directory resolution for FromUser/FromUserExternal config hints: resolve to parent directory for file paths and use session base path for external configs, matching the project_path resolution logic below.

ematipico · 2026-03-16T15:06:46Z

@mvanhorn linting and tests don't pass. Please make sure to test things locally

- Use map_or_else instead of map().unwrap_or_else() in session.rs - Update can_read_configuration_from_user_home snapshot for new message format - Verified tests and clippy pass locally

mvanhorn · 2026-03-16T15:48:46Z

Fixed in 19f3ec6: resolved the clippy map_unwrap_or lint in session.rs and updated the snapshot for the new diagnostic message format. Tests and clippy pass locally now.

AI disclosure: this PR uses Claude Code for implementation.

ematipico · 2026-03-17T10:09:30Z

CI is failing...

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

mvanhorn · 2026-03-17T14:29:05Z

Fixed the clippy map_unwrap_or lint in adff44b - replaced .map().unwrap_or() with .map_or_else().

mvanhorn · 2026-03-17T15:10:38Z

Thanks for the merge and the thorough review on #9489 too - learned a lot about biome's test infrastructure conventions.

github-actions bot added A-CLI Area: CLI A-Project Area: project A-LSP Area: language server protocol labels Mar 15, 2026

coderabbitai bot reviewed Mar 15, 2026

View reviewed changes

crates/biome_cli/src/runner/mod.rs Outdated Show resolved Hide resolved

crates/biome_lsp/src/session.rs Show resolved Hide resolved

mvanhorn and others added 2 commits March 15, 2026 08:45

chore: add changeset for biomejs#9463

2103db9

fix(diagnostic): use config file path instead of directory path

79d801c

Show the actual configuration file path in the ConfigurationOutsideProject diagnostic instead of just the directory path. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

ematipico reviewed Mar 16, 2026

View reviewed changes

fix: resolve clippy map_unwrap_or lint and update snapshot

19f3ec6

- Use map_or_else instead of map().unwrap_or_else() in session.rs - Update can_read_configuration_from_user_home snapshot for new message format - Verified tests and clippy pass locally

ematipico approved these changes Mar 17, 2026

View reviewed changes

fix: resolve clippy map_unwrap_or lint in runner

adff44b

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

ematipico merged commit bc709f6 into biomejs:main Mar 17, 2026
13 checks passed

github-actions bot mentioned this pull request Mar 17, 2026

ci: release #9517

Merged

	.unwrap_or_else(\|\| "<unknown>".to_string());
	.unwrap_or("<unknown>".to_string());

	let config_path_str = config_file_path
	let config_file_path = config_file_path

Uh oh!

Conversation

mvanhorn commented Mar 15, 2026

Summary

Test Plan

AI Assistance

Uh oh!

changeset-bot bot commented Mar 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

coderabbitai bot commented Mar 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Walkthrough

Possibly related PRs

Suggested labels

Suggested reviewers

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ematipico Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

mvanhorn Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

ematipico Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

mvanhorn Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

ematipico Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

mvanhorn Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ematipico commented Mar 16, 2026

Uh oh!

mvanhorn commented Mar 16, 2026

Uh oh!

ematipico commented Mar 17, 2026

Uh oh!

mvanhorn commented Mar 17, 2026

Uh oh!

Uh oh!

mvanhorn commented Mar 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

changeset-bot bot commented Mar 15, 2026 •

edited

Loading

coderabbitai bot commented Mar 15, 2026 •

edited

Loading