Integrate changes from microbit-foundation 0.1.0 tag#82
Integrate changes from microbit-foundation 0.1.0 tag#82microbit-sam wants to merge 11 commits intobbcmicrobit:masterfrom
Conversation
The aim of this is to create a new 'legacy' branch that has the features of the latest editor but the MicroPython version of the past. This is what we will expect people migrating from microbit.co.uk to use first.
This reverts commit 13ded9b.
microbit-sam
force-pushed
the
0.1.0-clean
branch
from
758a86b to
fb8d43b
Compare
|
Can't comment on the editor.html file in the code view, so I'll add the comment here. Looks like the version string is different on this branch, if your starting point was bbcmicrobit/PythonEditor master, then it means something has changed it from '0.1.0' to '0.0.0': Lines 72 to 73 in fb8d43b Both bbcmicrobit/PythonEditor@master and foundation/python-editor@v1.0.0 have that string as '0.1.0'. I think we should divert from both and set this to '1.0.0', as that is what we are calling this version of the editor. Can we also update the changelog to include info about all these changes? |
| @@ -0,0 +1 @@ | |||
| 0.1.0 | |||
There was a problem hiding this comment.
Let's change this to 1.0.0 as well.
| @@ -0,0 +1 @@ | |||
| 0.1.0 | |||
There was a problem hiding this comment.
If we need to update this on this release, can we also add it to the RELEASE_TODO.rst file?
| @@ -0,0 +1 @@ | |||
| 0.1.0 | |||
There was a problem hiding this comment.
Btw, I am not sure why this file is here and what it does, do you have more context @microbit-sam ?
| } | ||
|
|
||
| #script-description { | ||
| display: none; /* TODO: FIXME: remove this field */ |
There was a problem hiding this comment.
If we are removing this box from the UX we should probably just remove all the associated code with it.
We should only do that after both repos are synced, so opened #83.
|
The MicroPython version in the editor.html and firmware.hex files are different, could we replace these to be the same as the python-editor@v1.0.0? |
|
I just noticed I was comparing this as if it was the v1.0.0 release. Looking at the diff between 0.1.0 and 1.0.0 (https://github.com/microbit-foundation/python-editor/compare/0.1.0...1.0.0), I think we can just cherry pick https://github.com/microbit-foundation/python-editor/commit/ee2edb1dbdcf12d79d4434d63d28ec756a1857f7 and call this branch/PR the 1.0.0 merge. |
|
Tried to replace this with 1.0.0-clean and deleted the branch |
4 participants
Bring in changes from the Microbit Educational Foundation fork