fix: hide placeholder when tags exist in allowed file extensions input#2905
fix: hide placeholder when tags exist in allowed file extensions input#2905Bhaaru2 wants to merge 1 commit intoappwrite:mainfrom
Conversation
Console (appwrite/console)Project ID: Sites (1)
Tip MCP server integration brings LLM superpowers to Claude Desktop and Cursor IDE |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThis change modifies the placeholder behavior in the inputTags component. The placeholder prop passed to the Input.Tags element is now conditionally set: when tags exist (tags.length is truthy), the placeholder displays as an empty string; otherwise, it displays the provided placeholder value. This is a single-line logic change affecting how the input field's placeholder text is rendered based on tag presence. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR fixes a minor UX issue in the Key changes:
The fix is minimal, correct, and idiomatic Svelte — the template expression is automatically reactive because Confidence Score: 5/5
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[InputTags renders] --> B{tags.length > 0?}
B -- Yes --> C[placeholder = '' empty string]
B -- No --> D[placeholder = original placeholder prop]
C --> E[Input.Tags rendered — no placeholder shown]
D --> F[Input.Tags rendered — placeholder text visible]
E --> G{User removes all tags?}
G -- Yes --> B
G -- No --> E
F --> H{User adds a tag?}
H -- Yes --> B
H -- No --> F
Last reviewed commit: 745c6ca |
|
Tested the fix locally. Steps:
Result: |

What does this PR do?
Fixes the placeholder behavior in the allowed file extensions input.
Previously, when users added file extensions (tags), the placeholder text shifted to the right instead of disappearing. This change hides the placeholder once tags exist, ensuring consistent input behavior.
Test Plan
Related Issues
Fixes #1018
Summary by CodeRabbit