Einsum operator : final changes, fused computation#2391
Closed
HubertKrawczyk wants to merge 13 commits intoapache:mainfrom
Closed
Einsum operator : final changes, fused computation#2391HubertKrawczyk wants to merge 13 commits intoapache:mainfrom
HubertKrawczyk wants to merge 13 commits intoapache:mainfrom
Conversation
Contributor
|
LGTM - thanks for the completed einsum framework @HubertKrawczyk. The performance improvements compared to PyTorch, TensorFlow and NumPy are very impressive, and the failing CholeskyTest is not affected by your work and also works fine in my environment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Einsum framework compiles the execution into a plan of EOpNode-s.
Greedy path construction utilizing EOpNodeFuse which perform fused operations on multiple inputs if possible.
@mboehm7