[SPARK-44121][CONNECT][TESTS] Renable Arrow-based connect tests in Java 21#42643
Closed
dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-44121][CONNECT][TESTS] Renable Arrow-based connect tests in Java 21#42643dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
Conversation
dongjoon-hyun
changed the title
dongjoon-hyun
force-pushed
the
SPARK-44121
branch
from
45bbd9c to
8d17d5a
Compare
dongjoon-hyun
force-pushed
the
SPARK-44121
branch
from
8d17d5a to
08b5cb1
Compare
LuciferYang
reviewed
Aug 24, 2023
| * SPARK-44259: override test function to skip `RemoteSparkSession-based` tests as default, we | ||
| * should delete this function after SPARK-44121 is completed. | ||
| */ | ||
| override protected def test(testName: String, testTags: Tag*)(testFun: => Any)(implicit |
Contributor
There was a problem hiding this comment.
Sorry, please ignore my previous comment.
Member
Author
There was a problem hiding this comment.
No problem at all. Thank you for review!
LuciferYang
reviewed
Aug 24, 2023
| } | ||
|
|
||
| override def beforeAll(): Unit = { | ||
| // TODO(SPARK-44121) Remove this check condition |
Contributor
There was a problem hiding this comment.
I suggest these changes could be merged into 3.5 to avoid future conflicts. WDYT @dongjoon-hyun
Contributor
There was a problem hiding this comment.
At least the current one related to connect.
Member
Author
There was a problem hiding this comment.
For this connect area, I'll follow your guideline because you are the original author, @LuciferYang . :)
Member
Author
|
Could you review this PR, @LuciferYang ? The |
LuciferYang
approved these changes
Aug 24, 2023
Contributor
LuciferYang
left a comment
LuciferYang
left a comment
There was a problem hiding this comment.
I have also manually verified it with Java 21.
LGTM ~
Member
Author
|
Thank you so much, @LuciferYang ! |
dongjoon-hyun
added a commit
that referenced
this pull request
Aug 24, 2023
…va 21 ### What changes were proposed in this pull request? This PR aims to re-enable Arrow-based connect tests in Java 21. This depends on #42181. ### Why are the changes needed? To have Java 21 test coverage. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? ``` $ java -version openjdk version "21-ea" 2023-09-19 OpenJDK Runtime Environment (build 21-ea+32-2482) OpenJDK 64-Bit Server VM (build 21-ea+32-2482, mixed mode, sharing) $ build/sbt "connect/test" -Phive ... [info] Run completed in 14 seconds, 136 milliseconds. [info] Total number of tests run: 858 [info] Suites: completed 20, aborted 0 [info] Tests: succeeded 858, failed 0, canceled 0, ignored 0, pending 0 [info] All tests passed. [success] Total time: 44 s, completed Aug 23, 2023, 9:42:53 PM $ build/sbt "connect-client-jvm/test" -Phive ... [info] Run completed in 1 minute, 24 seconds. [info] Total number of tests run: 1220 [info] Suites: completed 24, aborted 0 [info] Tests: succeeded 1220, failed 0, canceled 0, ignored 0, pending 0 [info] All tests passed. [info] Passed: Total 1222, Failed 0, Errors 0, Passed 1222 ``` ### Was this patch authored or co-authored using generative AI tooling? No. Closes #42643 from dongjoon-hyun/SPARK-44121. Authored-by: Dongjoon Hyun <dhyun@apple.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com> (cherry picked from commit a824a6d) Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Member
Author
|
To all, although |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to re-enable Arrow-based connect tests in Java 21.
This depends on #42181.
Why are the changes needed?
To have Java 21 test coverage.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
No.